[FIX] When using TTX styles, email templates are ignored.

[enturion]

I am working on following case. I want Troubletickets to work in 2 languages. Dutch and English.
I have added a template directory nl and translated the newticket.txt.
If I ad a new ticket with ttx.cgi?style=nl everything works OK, the ticket window is in the right language and the confirmation is also. Only the confirmation email that is send to the mailbox of the client is in default english. The helpdesk is not using newticket.txt that is uploaded to the nl directory.
How do I get this right?



edit by sparky:  more descriptive topic subject line

[Sparky]

From this posting by Alex...

You may consider using styles. Style is a set of templates.

1) Create a directory under templates directory. Name it site1 (just an example, you may use any name).

2) Copy all files under templates directory to the site1

3) Execute Trouble Ticket Express via the following URL

ttx.cgi?style=site1

it will use templates form site1 subdirectory.

If a template does not exist in the specified style folder, the script will use default template.

The feature is not documented yet, but it is stable and will be preserved in the future versions.

Yes, you are requesting this in the correct forum, however for now you'll have to try to fix this yourself, wait for a solution to be posted here, or wait for Alex to fully implement the feature in a future release.

Email templates are called up in the TTXTicket.pm module in the usernotify and opernotify subroutines.

[Sparky]

You can try this...  I just whipped it out so it's not tested yet...

Find this piece in both the usernotify and opernotify subroutines of TTXTicket.pm...

if (open(TMPL, $cfg->get('basedir')."/templates/$tmpl.txt")) {
    my @buff = <TMPL>;
    close TMPL;
    $tmpl = join('', @buff);
  }

replace it all with this...

my $query;
my $style;
my $fn = $cfg->get('basedir')."/templates";
  if ($query->param('style') ne undef) {
    my @parts = split(/\/|\\/, $query->param('style'));
    $style = pop @parts;
  }
if (($style ne undef && open(TMPL, "$fn/$style/$tmpl.txt")) || open(TMPL, "$fn/$tmpl.txt")) {
    my @buff = <TMPL>;
    close TMPL;
    $tmpl = join('', @buff);
  }

Edit:  Jump down to the modifications...

http://forum.unitedwebcoders.com/index.php/topic,719.msg4072.html#msg4072

[enturion]

This error happens after changing:
Fatal Error: Unable to load module TTXTicket

syntax error at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 89, near "$style my " Global symbol "$fn" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 89. Global symbol "$query" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 90. Global symbol "$query" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 91. Global symbol "$fn" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 94. Global symbol "$fn" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 94. Compilation failed in require at (eval 11) line 2. BEGIN failed--compilation aborted at (eval 11) line 2.

SD:C:/Inetpub/helpdesk/helpdesk

You can try this...  I just whipped it out so it's not tested yet...

Find this piece in both the usernotify and opernotify subroutines of TTXTicket.pm...

if (open(TMPL, $cfg->get('basedir')."/templates/$tmpl.txt")) {
    my @buff = <TMPL>;
    close TMPL;
    $tmpl = join('', @buff);
  }

replace it all with this...

my $style
my $fn = $cfg->get('basedir')."/templates";
  if ($query->param('style') ne undef) {
    my @parts = split(/\/|\\/, $query->param('style'));
    $style = pop @parts;
  }
if (($style ne undef && open(TMPL, "$fn/$style/$tmpl.txt")) || open(TMPL, "$fn/$tmpl.txt")) {
    my @buff = <TMPL>;
    close TMPL;
    $tmpl = join('', @buff);
  }

[Sparky]

Two dumb mistakes on my part.   

Forgot to mention a variable and forgot a semi-colon.

See corrections in red above.

No more compilation errors but still not tested for functionality.

[enturion]

The correct code was not included.

Two dumb mistakes on my part.   

Forgot to mention a variable and forgot a semi-colon.

See corrections in red above.

No more compilation errors but still not tested for functionality.

[Sparky]

The correct code was not included.

Two dumb mistakes on my part.   

Forgot to mention a variable and forgot a semi-colon.

See corrections in red above.

No more compilation errors but still not tested for functionality.

Yes it was.  Here....

http://forum.unitedwebcoders.com/index.php/topic,719.msg4048.html#msg4048

[enturion]

This is the error I get after submitting a ticket:
CGI Error
The specified CGI application misbehaved by not returning a complete set of HTTP headers.

[Sparky]

This is the error I get after submitting a ticket:
CGI Error
The specified CGI application misbehaved by not returning a complete set of HTTP headers.

Yes, I just got that error too.  Ticket was created and confirmation email was sent but something went very wrong when re-directing to the confirmation page.

We gave it a shot but I don't have any more time to troubleshoot this today.

Since tickets are still created and confirmation emails sent, I'm sure this is something simple.

Just go back to your original files for now.

[Sparky]

SOLVED -> The following was fully tested in TTX version 2.24 with a duplicate template set.   

All the modifications below are performed on the TTXTicket.pm module


1.  In the usernotify subroutine

a.  find this line and ADD the parts in blue...

my $name = $ticket->{'name'};
my $style = $_[0]->{style};
my $fn = $cfg->get('basedir')."/templates";

b.  find the line in red and REPLACE with the blue.  (NOTE:  In TWO places within this subroutine.)

if (open(TMPL, $cfg->get('basedir')."/templates/$tmpl.txt")) {
if (($style ne undef && open(TMPL, "$fn/$style/$tmpl.txt")) || open(TMPL, "$fn/$tmpl.txt")) {
   my @buff = <TMPL>;
   close TMPL;
   $tmpl = join('', @buff);
  }

2.  In the opernotify subroutine

a.  find this line and ADD the parts in blue...

my $ticket = $_[0]->{ticket};
my $style = $_[0]->{style};
my $fn = $cfg->get('basedir')."/templates";

b.  find the line in red and REPLACE with the blue.  (In ONE place within this subroutine.)

if (open(TMPL, $cfg->get('basedir')."/templates/$tmpl.txt")) {
if (($style ne undef && open(TMPL, "$fn/$style/$tmpl.txt")) || open(TMPL, "$fn/$tmpl.txt")) {
   my @buff = <TMPL>;
   close TMPL;
   $tmpl = join('', @buff);
  }

3.  In the newticket subroutine

a.  find this line and ADD the parts in blue...

my ($cfg, $query, $data) = @_;
my $style = $query->param('style');

b.  find each line and ADD the parts in blue....

usernotify({cfg => $cfg, ticket => $ticket, style => $style, validationcode => $data->{VALIDATIONCODE}})

my $opernotifydata = {cfg => $cfg, ticket => $ticket, style => $style};

4.  In the ticket subroutine

a.  find this line and ADD the parts in blue...

TTXCommon::tickedvars($cfg, $data);
my $style = $query->param('style');

b.  find each line and ADD the parts in blue....

usernotify({cfg => $cfg, ticket => $t, style => $style,

my $opernotifydata = {cfg => $cfg, ticket => $t, style => $style};

opernotify({cfg => $cfg, ticket => $t, style => $style});

my $opernotifydata = {cfg => $cfg, ticket => $t, style => $style};

my $opernotifydata = {cfg => $cfg, ticket => $t, style => $style};

opernotify({cfg => $cfg, ticket => $t, style => $style});

[enturion]

A lot of changing in the code. It was easier just to drop the file.  Anyway this error appears
Fatal Error: Unable to load module TTXTicket

Global symbol "$style" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 302. Global symbol "$fn" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 302. Global symbol "$style" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 302. Global symbol "$fn" requires explicit package name at C:/Inetpub/helpdesk/helpdesk/TTXTicket.pm line 302. Compilation failed in require at (eval 23) line 2. BEGIN failed--compilation aborted at (eval 23) line 2.

In line 302 is clearly something wrong. I double checked it and its exact like above stated:
if (($style ne undef && open(TMPL, "$fn/$style/$tmpl.txt")) || open(TMPL, "$fn/$tmpl.txt")) {

[Sparky]

A lot of changing in the code. It was easier just to drop the file.

 

And it would be easier for me to just tell you to wait for Alex to fix the feature in a future release.  So I hope you're not complaining to me, a volunteer, about having to contribute just a little bit of effort yourself.   

Besides, most importantly, I won't drop files since many people already have other modifications applied and would have to manually re-apply those anyway.  I'm only here to point you in the right direction, make suggestions, and help out where-ever I can... I'm not here to simply write & upload modifications on demand.  In the process of manually editing, a user might actually learn something about how these modifications work.   


Line 302 is in the opernotify subroutine so carefully double-check the edit that comes before line 302...  step 2a...

That error means that the following is either missing, incorrect, or corrupted...

my $style = $_[0]->{style};
my $fn = $cfg->get('basedir')."/templates";

[enturion]

I understand. We are all slaves of our interest to make it work.
Tomorrow I will give it a try again and put the file, if working, for download. If Alex agrees of course.
THX any way for your help.

[Sparky]

Tomorrow I will give it a try again and put the file, if working, for download.

Please do not post download links to any modified TTX files as there is no way to verify the integrity of such files.  We also don't need a bunch of variations of something with the same file name posted all over the place.   

The modification is already posted here for everyone to see and apply as they see fit.

This forum is about users learning to apply their own modifications to TTX.  These modifications are not supported by Alex.

Edit:  Solution verified.  Thread locked.