[REQ] Date Range option in reports

[arvin]

I see that the (%TICKETFILTER%) has the date range code within it and the that (%TICKETFILTER%) is in the reports.html page .... shouldn't I be able to select a date range when building my reports?

[Sparky]

Apparently not, according to the Demo site.

[Sparky]

Is it really the same macro coming from the same subroutine?

[arvin]

Is it really the same macro coming from the same subroutine?

from what I can see ....yes

[Sparky]

TTXReports fltrcode subroutine calls this...

TTXDesk::buildfilter($cfg,$query,$data)

... which we already know.

But the fltrcode subroutine, if you notice, is what builds the filter ($data) before calling the buildfilter subroutine.  Also notice that there is a variable called $nodr... (no date range?) before calling the buildfilter subroutine.

if ($nodr || $nostatus) {
    my @newflds;
    foreach my $fld (split(/\|/, $saveflds)) {
      next if $fld eq 'drange' && $nodr;
      next if $fld eq 'status' && $nostatus;
      push @newflds, $fld;
    }
    $cfg->set('fltrcols', join('|', @newflds));
  }
  if ($nodr) {
    $query->param(-name => 'drange', -value => '');
  }

Track down & figure out this $nodr variable and you may have solved it.  Perhaps a new option you can put in the Config file.

[arvin]

BINGO !

That did it ....I commented out the following code ... and tested it ... the date range now shows up on the Report template.....I don't know if it will actually do anything yet ...... but it shows up 

Code:

   

##my @newflds;
    ##foreach my $fld (split(/\|/, $saveflds)) {
      ##next if $fld eq 'drange' && $nodr;
      ##next if $fld eq 'status' && $nostatus;
      ##push @newflds, $fld;
    ##}
    ##$cfg->set('fltrcols', join('|', @newflds));
  ##}
  ##if ($nodr) {
    ##$query->param(-name => 'drange', -value => '');
  ##}
  ##if ($nostatus) {
    ##$query->param(-name => 'status', -value => '');

[Sparky]

It's a start but I recommend a simpler solution.

Perhaps you can just set $nodr to a different value and get the same result?

[Sparky]

Find our where $nodr comes from and figure out how to set it to zero....  you'll probably get the same result with a cleaner/simpler mod.

[arvin]

I hear ya ......

So far I find $nodr in the fltrcode sub routine only .... i've checked all other modules ...and found nothing .... Given that .....Couldn 't I just removed  "$nodr, $nostatus" and all references to them with in TTXReports? .....

 

sub fltrcode {
  my ($cfg, $query, $data, $nodr, $nostatus) = @_;

[Sparky]

try  $nodr = 0;

sub fltrcode {
  my ($cfg, $query, $data, $nodr, $nostatus) = @_;
  $nodr = 0;

[arvin]

 

I added that ..... and reversed the my changes and tested it ...and it works as well.

[Sparky]

I'm not sure of his intentions.  Since $nodr and $nostatus aren't set to anything anyplace, not sure what they're doing.  Probably part of something not yet implemented.

You could probably also get it from the config file

$nodr = $cfg->get('noreportsdaterange');

in ttxcfg.cgi:

noreportsdaterange = 0

[webcarvallo]

I added that ..... and reversed the my changes and tested it ...and it works as well.

Hi Arvin,  At last... ¿Can you figure out the way to get the date filter work?.
  I can get the date range filter showing at the reports page, but nothing (new) happens if I select a date range to get report.  ¿Had you got it?
Thanks in advance.
Andrés.